Skip to content

feat(harness): add PR template and REVIEW.md - #30

Merged
fmflurry merged 1 commit into
masterfrom
feat/pr-template-review-md
Oct 18, 2026
Merged

fmflurry merged 1 commit into
masterfrom
feat/pr-template-review-md

Conversation

@fmflurry

Copy link
Copy Markdown
Owner

Summary

Step 3 of the harness action plan. When a repository has REVIEW.md, the reviewer reads it and uses it as the single reference for the tag mapping (Important, Nit, Pre-existing). The report cites that file. When REVIEW.md is absent, the reviewer says so and uses the default tag rules in code-reviewer.

.github/pull_request_template.md adds Risk, How to revert, and Tier. /pr and /create-pull-request read REVIEW.md and fill that template. /setup-harness offers the same template to a project that does not already have one. Claude, OpenCode, and the regenerated Cursor plugin all carry the read rule. Plugin version is 0.4.2 (patch only).

Always-loaded Cursor rules: 1438 → 1438 lines (delta 0), still 21 always-applied files. No always-on rule was added or edited. The new text is in the code-reviewer agent, the /pr command, and the setup-harness skill.

Risk

A repository that adds its own REVIEW.md replaces the default tag table. A shorter or different file changes what blocks a merge. This repository's REVIEW.md restates the current default, so reviews here keep the same tags and must cite the file.

How to revert

Revert 617d782. That restores plugin 0.4.1 and removes REVIEW.md, .github/pull_request_template.md, and the /pr command.

Tier

T2. The diff is harness instructions and the generated plugin. It does not touch application code, secrets, or a protected path. T3 would need a cross-check and a human review; this does not.

Checks

  • node scripts/cursor-plugin/check.mjs: cursor-plugin check OK
  • bash scripts/agent-harness/test/run.sh: tests: 1269 passed, 0 failed
  • npm test: 68 passed, 2 skipped, 1 failed. The failure is the known pre-existing one, OpenCode local install syncs the repository config payload exactly.
  • npx tsc --noEmit --pretty false --project tsconfig.strict.json: exit 0
Open in Web Open in Cursor 

The reviewer reads REVIEW.md when a repository has one and uses it
as the single reference for Important, Nit, and Pre-existing. Otherwise
it keeps the default tag rules. /setup-harness offers the pull request
template (Risk, How to revert, Tier) to projects that do not have one.

Co-authored-by: Florian <fmflurry@users.noreply.github.com>
@fmflurry
fmflurry merged commit 62aa030 into master Oct 18, 2026
1 check passed
@fmflurry
fmflurry deleted the feat/pr-template-review-md branch October 18, 2026 06:18
fmflurry added a commit that referenced this pull request Oct 18, 2026
* docs(readme): document shipped harness changes and ship

Record #25 through #30 from the tree, including both no-progress
checks, and state how /ship is launched in each harness.

Co-authored-by: Florian <fmflurry@users.noreply.github.com>

* docs(readme): record the rules diet in recent changes

#32 cut always-applied Cursor rules from 21 files to 7. The verification
skill and the socratic spike stay unshipped.

Co-authored-by: Florian <fmflurry@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Florian <fmflurry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants