Repository navigation
Migrate to bootstrap 4 - #1209
Merged
Merged
Conversation
chalin
added
the
infra.structure
googlebot
added
the
cla: yes
Contributor
|
Wow! What a lot of work, @chalin. I scanned the file changes and played with the staged site. It looks great! |
Contributor
|
LGTM from me, but waiting for @filiph to weigh in. |
filiph
approved these changes
Aug 30, 2018
filiph
left a comment
filiph
left a comment
Contributor
There was a problem hiding this comment.
Really good stuff, thank you! I like that you added new documentation comments as well.
Added a few nits but feel free to land.
| {% include main-nav.html class="nav-item" %} | ||
| </div> | ||
|
|
||
| <div class="site-nav-vertical dropdown"> |
Contributor
There was a problem hiding this comment.
[nit] The current version shows the drop down on mouse-over, and it also shows cursor: hand.
Contributor
Author
There was a problem hiding this comment.
The hover behavior is non-standard for menus/dropdowns, and doesn't work on mobile. I'll address the cursor in a followup PR.
Contributor
Author
There was a problem hiding this comment.
I'll address the cursor in a followup PR.
Fixed in #1220.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1194
Staged at https://ng2-io.firebaseapp.com
cc @filiph @fertolg