Repository navigation
feat(vitest): add toHaveLengthMatchers rule - #3650
Merged
michaelfaith merged 3 commits intoOct 12, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 5c5e16c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for flint-fyi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@flint.fyi/astro
@flint.fyi/astro-language
@flint.fyi/browser
@flint.fyi/changesets
@flint.fyi/cli
@flint.fyi/core
@flint.fyi/css
@flint.fyi/css-language
flint
@flint.fyi/json
@flint.fyi/json-language
@flint.fyi/jsx
@flint.fyi/markdown-language
@flint.fyi/md
@flint.fyi/next
@flint.fyi/node
@flint.fyi/nuxt
@flint.fyi/package-json
@flint.fyi/performance
@flint.fyi/plugin-flint
@flint.fyi/react
@flint.fyi/rule-data
@flint.fyi/rule-tester
@flint.fyi/solid
@flint.fyi/spelling
@flint.fyi/svelte
@flint.fyi/svelte-language
@flint.fyi/text-language
@flint.fyi/ts
@flint.fyi/ts-patch
@flint.fyi/typescript-language
@flint.fyi/utils
@flint.fyi/vitest
@flint.fyi/volar-language
@flint.fyi/vue
@flint.fyi/vue-language
@flint.fyi/yaml
@flint.fyi/yaml-language
commit: |
lishaduck
approved these changes
Oct 9, 2026
lishaduck
left a comment
lishaduck
left a comment
Member
There was a problem hiding this comment.
Great first contribution, thanks for the PR!
lishaduck
added
the
1 approval
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 of 3 tasks
michaelfaith
approved these changes
Oct 9, 2026
michaelfaith
left a comment
michaelfaith
left a comment
Member
There was a problem hiding this comment.
Awesome first contribution! Nice work. Just a few nits from me. Let us know once you have those addressed, and one of us will merge.
michaelfaith
added
status: waiting for author
Contributor
Author
|
@michaelfaith @lishaduck nits addressed Thanks! |
michaelfaith
enabled auto-merge (squash)
October 12, 2026 17:49
michaelfaith
added
ready to merge
Contributor
|
@all-contributors please add amitreny for code.
|
Contributor
|
@github-actions[bot] I've put up a pull request to add @amitreny! 🎉 |
michaelfaith
pushed a commit
that referenced
this pull request
Oct 12, 2026
Adds @amitreny as a contributor for code. This was requested by github-actions[bot] [in this comment](#3650 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
toHaveLengthMatchersrule #2698status: accepting prsOverview
toHaveLengthMatchers rule for the Vitest plugin have been ported from vitest/prefer-to-have-length
matches: toBe, toEqual and toStrictEqual on an expect() argument ending in .length or ["length"], including through .not
skips: optional chains such as expect(files?.length), because toHaveLength() throws on undefined.
🫡