Skip to content

Quick fix to solve discriminator problem of CommunicationDetails #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorritn merged 1 commit into from
Nov 25, 2025
+2 −2
Merged

Quick fix to solve discriminator problem of CommunicationDetails #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/s2auth/common/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from __future__ import annotations

from enum import Enum
from typing import List, Optional
from typing import List, Literal, Optional
from uuid import UUID

from pydantic import AnyUrl, AwareDatetime, BaseModel, Field, RootModel, constr
Expand Down Expand Up @@ -39,7 +39,7 @@ class UnpairPostRequest(BaseModel):


class CommunicationDetails(BaseModel):
communicationProtocol: CommunicationProtocol
communicationProtocol: Literal['WebSocket']


class WebSocketCommunicationDetails(CommunicationDetails):
Expand Down