Pydantic throws an error on CommuncationDetails subclasses #19

Activity

1. jorritn commented on Nov 25, 2025

   

   jorritn

   on Nov 25, 2025

   ContributorAuthor

   More actions

   There are a couple of things wrong. First of all, we need the discriminator in the generic ConnectionDetails object in the OpenAPI definition. Furthermore, there is an open PR to support the discriminator in the datamodel-code-gen tool (which is used by fast-api-codegen).
2. jorritn commented on Nov 25, 2025

   

   jorritn

   on Nov 25, 2025

   Last edited by jorritn

   ContributorAuthor

   More actions

   Quick fix is changing the type of the communicationProtocol field of the CommuniationDetails class to:

   communicationProtocol: Literal['Websocket'] | Literal['SomeOtherProtocol']
3. jorritn

   linked a pull request that will close this issueQuick fix to solve discriminator problem of CommunicationDetails #21on Nov 25, 2025
4. jorritn

   removed a link to a pull requestQuick fix to solve discriminator problem of CommunicationDetails #21on Nov 25, 2025
5. jorritn commented on Nov 25, 2025

   

   jorritn

   on Nov 25, 2025

   ContributorAuthor

   More actions

   I've added the discriminator to the openapi spec #22 Still need to generate the models again once the PR that fixes this in the datamodel generator datamodel-code-generator/datamodel-code-generator#2530
6. jorritn

   self-assigned this

   on Jan 26, 2026
7. jorritn commented on Feb 5, 2026

   

   jorritn

   on Feb 5, 2026

   ContributorAuthor

   More actions

   Is fixed in datamodel-code-generator version 0.37.0. We're using a recent version now.
8. jorritn

   closed this as completedon Feb 5, 2026
9. jorritn

   reopened this on Feb 5, 2026
10. jorritn commented on Feb 5, 2026

    

    jorritn

    on Feb 5, 2026

    ContributorAuthor

    More actions

    After upgrading to datamodel-code-generator version 0.53.0 the validation error persists... So I've applied the quick fix again