[bkendall]

Converts src/middleware/redirects.js and test/unit/middleware/redirects.spec.js to TypeScript (src/middleware/redirects.ts and test/unit/middleware/redirects.spec.ts).

• Reuses Redirect and Configuration types and patterns.configMatcher / patterns.createRaw from src/utils/patterns.ts.
• Replaces internal Redirect constructor function with a typed class/interface while preserving exact path-to-regexp capture, query string preservation, and CommonJS factory export compatibility for src/superstatic.js.

[gemini-code-assist]

Code Review

This pull request migrates the redirects middleware and its unit tests from JavaScript to TypeScript, refactoring the redirect logic into a structured Redirect class and updating tests to use modern async/await syntax. The review feedback suggests several key improvements: caching compiled Redirect instances with a WeakMap to boost performance, wrapping decodeURI in a try-catch block to prevent crashes on malformed URLs, passing configuration errors to next() instead of throwing them directly, and using indexOf and slice to parse query strings more robustly.

[joehan]

Code Review: PR #616 (refactor(middleware): convert redirects middleware and tests to TypeScript)

Strengths & LGTM Aspects

• Clean extraction of redirect config caching and pattern matching.
• Strong test suite covering status codes and redirect targets.

Key Findings to Address

1. return next(new Error(...)) fails open inside superstatic: In src/activator.js, _run() takes zero arguments. Passing an error to next(err) pops the next middleware instead of terminating the request, silently serving static files 200 OK on malformed redirect configs.
2. decodeURI(req.url) before ? lets ?% bypass all redirects: Decoding the full req.url before splitting the query string catches URIError on requests like GET /source?discount=50%, calls next(), and bypasses all redirect rules to serve source.html with 200 OK.
3. encodeURI(addQuery(dest, qs)) double-encodes query parameters: Reserved query escapes like %26 or %3A in the query string get double-encoded to %2526.
4. 0-argument factory function: export = function () accepts 0 arguments, failing TS2554 when called as redirects(spec) by activator.js.