Repository navigation
fix(fcm): A workaround for the concurrency issues in googleapiclient - #558
Merged
Merged
Conversation
lahirumaramba
approved these changes
Jun 25, 2021
lahirumaramba
left a comment
lahirumaramba
left a comment
Member
There was a problem hiding this comment.
Using a new transport makes sense to me. Thanks!
|
|
||
| batch = http.BatchHttpRequest( | ||
| callback=batch_callback, batch_uri=_MessagingService.FCM_BATCH_URL) | ||
| transport = self._build_transport(self._credential) |
Member
There was a problem hiding this comment.
Is the reason to use _build_trasnport here (instead of directly using _auth.authorized_http) so we can write tests easily?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible solution to the problem outlined in #507. I wasn't quite able to repro the exception in the bug report, but the threading issues in
googleapiclientare well known, and I can easily reproduce some concurrency issues by callingsend_all()from just 3-4 parallel threads. The proposed solution is to instantiate a new transport instance for each invocation ofsend_all()(as opposed to using a shared transport across calls), and tests indeed confirm that it resolves the issues I managed to reproduce.