You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
reviewstack.dev tab hanging when I try to view the relative diff against a previous version #1173
Not sure how to debug this as it's on a private repo, but both firefox and Chrome are hanging when I try to diff version 12 of a PR against latest. Attaching a firefox trace I captured of the issue (symbols appear to be minified so not sure how clear it'll be to someone what's going on)
4455abe should help a little bit. However, the root cause is slow memory management from recoil which is no longer maintained. I will work on migrating to jotai which I think will be a suitable replacement. This might take a while, appreciate your bugreport and patience.
By the way @vlovich the code is in here, https://github.com/facebook/sapling/tree/main/eden/contrib/reviewstack.dev , so you can run it locally and get non-minified symbols that way. This is a simple create-react-app project, nothing too fancy. However, since reviewstack is designed to be embeddable, some of the libs are actually included in the index.html file rather than the webpack bundle; so you could temporarily replace them with the dev version if needed.
Activity
bherila commentedon Jan 30, 2026
4455abe should help a little bit. However, the root cause is slow memory management from
recoilwhich is no longer maintained. I will work on migrating tojotaiwhich I think will be a suitable replacement. This might take a while, appreciate your bugreport and patience.By the way @vlovich the code is in here, https://github.com/facebook/sapling/tree/main/eden/contrib/reviewstack.dev , so you can run it locally and get non-minified symbols that way. This is a simple create-react-app project, nothing too fancy. However, since reviewstack is designed to be embeddable, some of the libs are actually included in the index.html file rather than the webpack bundle; so you could temporarily replace them with the dev version if needed.
bherila commentedon Feb 4, 2026
more progress (wip)
bherila commentedon Feb 6, 2026
More progress:
Additional improvements landed:
bherila commentedon Feb 9, 2026
This is all fixed now but blocked on #1205
I'm going to consider THIS issue completed but please watch there for upcoming release. You can pull the repo and run locally, details in #1205.