Skip to content

reviewstack.dev tab hanging when I try to view the relative diff against a previous version #1173

Open

Description

@vlovich

Not sure how to debug this as it's on a private repo, but both firefox and Chrome are hanging when I try to diff version 12 of a PR against latest. Attaching a firefox trace I captured of the issue (symbols appear to be minified so not sure how clear it'll be to someone what's going on)

Firefox 2026-01-13 17.13 profile.json.gz

Here's the chrome trace:

Trace-20260113T171727.zip

Activity

  1. self-assigned this
    on Jan 29, 2026
  2. bherila commented on Jan 30, 2026

    @bherila
    Contributor

    4455abe should help a little bit. However, the root cause is slow memory management from recoil which is no longer maintained. I will work on migrating to jotai which I think will be a suitable replacement. This might take a while, appreciate your bugreport and patience.

    By the way @vlovich the code is in here, https://github.com/facebook/sapling/tree/main/eden/contrib/reviewstack.dev , so you can run it locally and get non-minified symbols that way. This is a simple create-react-app project, nothing too fancy. However, since reviewstack is designed to be embeddable, some of the libs are actually included in the index.html file rather than the webpack bundle; so you could temporarily replace them with the dev version if needed.

  3. bherila commented on Feb 4, 2026

    @bherila
    Contributor

    more progress (wip)

    Commit Title Hash
    recoil to jotai migration 6/n – core PR atoms db5ac84
    recoil to jotai migration 5/n – core PR atoms 7916a98
    recoil to jotai migration 4/n – pull request labels reviewers 61c2d28
    recoil to jotai migration 3/n – repo assignable users, repo labels d522e01
    recoil to jotai migration 2/n – comment threads acba96c
    recoil to jotai migration 1/n – initial migration infra 97d47aa
    Fix commit list overflow with vertical scrolling 2f28000
    Fix EventTarget extension in KeyboardShortcuts 3f0864f
    Fix race condition in SharedWorker initialization 8d2d789
    Add binary content detection and large diff placeholder 60b40af
  4. bherila commented on Feb 6, 2026

    @bherila
    Contributor

    More progress:

    Title Hash
    Remove dead code from recoil.ts 8fc5896
    recoil to jotai migration 15/n - comment input state 8f866e9
    recoil to jotai migration 14/n - version and thread tracking d3ad1bb
    recoil to jotai migration 13/n - review threads and comments 36d0ded
    Add empty export to fix TypeScript module isolation 5b7cd63
    recoil to jotai migration 12/n - migrate pulls and blobs 56cd056
    recoil to jotai migration 11/n - consumer updates + check runs b1890f8
    recoil to jotai migration 10/n - consumer updates 0b07dea
    recoil to jotai migration 9/n - remove migrated selectors b0063ee
    recoil to jotai migration 8/n - PR version diff atoms bb7a4f2
    recoil to jotai migration 7/n - commit view 270a201

    Additional improvements landed:

    Title Hash
    Add Cmd/Ctrl+Enter keyboard shortcut to submit comments c6d8bf4
    Fix syntax highlighting by injecting TextMate CSS 81d7735
  5. bherila commented on Feb 9, 2026

    @bherila
    Contributor

    This is all fixed now but blocked on #1205

    I'm going to consider THIS issue completed but please watch there for upcoming release. You can pull the repo and run locally, details in #1205.

  6. added
    fix readyA fix was created. It's pending review or push.
    on Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions