Skip to content

Include ref.parent matches in events by-reference navigation - #2280

Open
niemyjski with Copilot wants to merge 19 commits into
mainfrom
copilot/fix-parent-url-navigation
Open

niemyjski with Copilot wants to merge 19 commits into
mainfrom
copilot/fix-parent-url-navigation

Conversation

Copilot AI commented May 31, 2026 •

Copy link
Copy Markdown
Contributor

By-reference navigation now finds both direct references and matching parent references on free and paid plans. The reference page keeps the same filter when opening the events list and reports the server total for its 20-event preview. Migration 10 backfills retained parent references while preserving existing indexed values. Custom-reference searches remain premium-only.

Validation after merging current main: 150 focused backend tests, 147 frontend tests, frontend validation (zero errors/warnings), production build, and whitespace checks passed.

Readiness limitations: refreshed hosted checks are pending; contributor CLA was previously pending and has not yet reported on the new revision. Service-backed migration/API checks were previously successful but have not been rerun after this merge. The local browser walkthrough remains blocked pending explicit authorization for test-account sign-in.

Verification and implementation details
  • Integrated main 29cdd9b098979e849e1e4255593c398f34c9f0a8 with a normal merge; preserved main's curated HTTP examples while retaining both by-reference requests.
  • Reviewed the complete effective diff across query validation, free-plan indexing, backfill behavior, route authorization, root Svelte routes, and client entitlement checks. No new actionable defect found in this pass.
  • Backend coverage includes migration task failures and registration, indexing normalization, retained reference compatibility, query validation, and field-name validation.
  • Frontend coverage includes built-in/custom reference filters, legacy numeric references, free-plan entitlement checks, and truncated result totals.
  • Earlier service-backed verification covered six migration cases, both free-plan by-reference routes, and free-plan ingestion; those results predate this integration.

@CLAassistant

CLAassistant commented May 31, 2026 •

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ niemyjski
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI linked an issue Jun 1, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix navigation issue from 'Parent' URL in Exceptionless 4.1.0 Include ref.parent matches in events by-reference navigation Jun 1, 2026
Copilot AI requested a review from niemyjski June 1, 2026 00:11
@niemyjski
niemyjski force-pushed the copilot/fix-parent-url-navigation branch from e666187 to 8f5e641 Compare July 10, 2026 18:47
@niemyjski
niemyjski changed the base branch from bugfix/1287-investigate-references to main July 10, 2026 18:47
@niemyjski
niemyjski marked this pull request as ready for review July 21, 2026 02:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ae3cc52eb3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Web/Api/Handlers/EventHandler.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f152edde5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 775c14f17c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Core/Pipeline/035_CopySimpleDataToIdxAction.cs Outdated
Comment thread src/Exceptionless.Web/Api/Handlers/EventHandler.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f0dd46364

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a507d669da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Core/Extensions/PersistentEventExtensions.cs Outdated
Comment thread src/Exceptionless.Core/Migrations/003_BackfillParentReferences.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85e61cecba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Core/Migrations/003_BackfillParentReferences.cs Outdated
@niemyjski

niemyjski commented Jul 26, 2026 •

Copy link
Copy Markdown
Member

Follow-up reviewer audit complete on head 2991ef0e0a00e9ee4ca52b1d1b3851a20939fdd4.

Feedback classification:

  • Four historical Codex threads were already fixed and outdated on the current diff.
  • The Svelte premium-guard P2 was already fixed by a507d669d; it was replied to and resolved.
  • Two Codex P1s were valid and fixed in 85e61cecb: SetEventReference again preserves legacy/custom names at the public write boundary, and migration 3 string-normalizes legacy parent values and rejects task errors, embedded failures, and version conflicts instead of completing partially.
  • A post-push Codex P2 was valid and fixed in 3e5f26322: persisted @ref:Parent and other casing variants are backfilled via a canonical-first, case-insensitive fallback.
  • A later Codex P2 was valid and fixed in d7a0b3764: the by-reference page consumes existing total metadata, labels the bounded preview honestly, and directs the complete parent-aware result set to the paginated Events view.
  • The final Codex P2 was valid and fixed in 2991ef0e0: the client premium guard now recognizes hyphenated and Unicode custom reference fields instead of silently disagreeing with backend entitlement enforcement.
  • Submitted-review boilerplate and coverage bot comments were informational; the Copilot CLA remains the sole external gate.

Thermo-nuclear review of the complete current branch-vs-main diff found and fixed a partial-update risk where Conflicts.Proceed could silently skip documents. It also drove a code-judo simplification of the client field extractor: the brittle duplicated character grammar was deleted while the free-field allowlist remains the canonical entitlement decision. No PR file crosses 1,000 lines because of this change, and no further structural, abstraction, type-boundary, or canonical-helper issue remains.

Local verification: backend build passed with 0 warnings/errors; compatibility tests 3/3; migration task-result tests 4/4; service-backed migration 1/1; free-plan ingestion 1/1; organization/project by-reference endpoints 2/2; query validator 70/70; frontend unit tests 332/332; focused reference-page tests 3/3; focused premium-filter tests 4/4; npm run validate passed with 0 Svelte errors/warnings; frontend production build, scoped dotnet format --verify-no-changes, and git diff --check passed. All ten review threads are resolved.

Authoritative GitHub Actions run 30212517562 passed on this exact head: API/coverage, client, E2E, Docker, and version are green. The external Copilot contributor CLA is the only pending check.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3e5f263221

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Web/Api/Handlers/EventHandler.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7a0b3764c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11f79ad9fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Core/Migrations/003_BackfillParentReferences.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4b3e97a43

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf2ac5279a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 90b02f9f94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Core/Pipeline/035_CopySimpleDataToIdxAction.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2409d9ce3f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Core/Migrations/006_BackfillParentReferences.cs Outdated
@niemyjski
niemyjski force-pushed the copilot/fix-parent-url-navigation branch from 2409d9c to a91445f Compare September 16, 2026 00:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T03:00:34.534447Z d75bddc New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 709d378046

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.AppHost 23% 23% 128 ❌
Exceptionless.Core 77% 69% 10967 ✔
Exceptionless.Insulation 51% 43% 370 ➖
Exceptionless.Web 86% 71% 9177 ✔
Summary 80% (28163 / 35143) 69% (13935 / 20228) 20642 ✔

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exceptionless 4.1.0 cannot navigate from the 'Parent' url

3 participants