Repository navigation
docs: explain how route and virtual host rate limits combine - #48408
Merged
yanavlasov merged 1 commit intoOct 22, 2026
Merged
Conversation
The rate limit filter page still points to the deprecated include_vh_rate_limits route field. Describe vh_rate_limits in RateLimitPerRoute instead, list its three values, and note that an empty rate_limits list on a route does not turn off the virtual host rate limits. Add an example that exempts one route with IGNORE. Signed-off-by: YoungjuKim <fjvbn2003@gmail.com>
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-cncf-pr/48408/docs/index.html The docs are (re-)rendered each time the CI |
|
Hi @fjvbn2003, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
yanavlasov
enabled auto-merge (squash)
October 21, 2026 14:33
yanavlasov
approved these changes
Oct 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
docs: explain how route and virtual host rate limits combine
The rate limit filter page still points to the deprecated
include_vh_rate_limitsroute field. Describevh_rate_limitsinRateLimitPerRouteinstead, list its three values, and note that an emptyrate_limitslist on a route does not turn off the virtual host rate limits. Add an example that exempts one route withIGNORE.Additional Description:
The page says "The route can optionally include the virtual host rate limit configurations" and links to
RouteAction.include_vh_rate_limits, which is deprecated in favour ofRateLimitPerRoute.vh_rate_limits. The page does not say what happens by default, and it does not mentionvh_rate_limitsat all. #15482 is a user asking how to usevh_rate_limits.A common way to try to exempt one route is
rate_limits: []on that route. That has no effect: in proto3 an empty repeated field is the same as an unset one, and the filter (Filter::populateRateLimitDescriptors,VhRateLimitOptions::Override) uses the virtual host policy whenroute_entry->rateLimitPolicy().empty().I checked this with Envoy 1.38.3 (
0ebfcfe5…/1.38.3/Clean/RELEASE/BoringSSL). The virtual host has onegeneric_keyrate limit, the filter hasfailure_mode_deny: true, and nothing listens on the rate limit service port, so a request gets 500 when a descriptor is sent and 200 when none is sent:config_dumpshows the/empty/route as{"match": {"prefix": "/empty/"}, "route": {"cluster": "echo"}}, so the empty list is dropped when the config is loaded.Risk Level: Low (docs only)
Testing: Checked the behaviour above with Envoy 1.38.3 and checked that the code path is the same on main. I did not build the docs locally; the enum value references use the same form as other pages (for example
envoy_v3_api_enum_value_extensions.filters.http.grpc_json_transcoder.v3.GrpcJsonTranscoder.UrlUnescapeSpec.ALL_CHARACTERS_EXCEPT_RESERVED).Docs Changes:
docs/root/configuration/http/http_filters/rate_limit_filter.rstRelease Notes: N/A
Platform Specific Features: N/A
This change was drafted with AI assistance and reviewed by me.
🤖 Generated with Claude Code