Skip to content

Repository navigation

Add BaseEvent interface - #260

Merged
florimondmanca merged 1 commit into
masterfrom
refactor/base-event
Aug 21, 2019
Merged

Add BaseEvent interface#260
florimondmanca merged 1 commit into
masterfrom
refactor/base-event

Conversation

@florimondmanca

@florimondmanca florimondmanca commented Aug 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add a BaseEvent interface to abstract away asyncio.Event(), esp. in ASGIDispatch.

Refs #247

lovelydinosaur
lovelydinosaur approved these changes Aug 21, 2019
View reviewed changes

@lovelydinosaur lovelydinosaur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@florimondmanca

florimondmanca commented Aug 21, 2019

Copy link
Copy Markdown
Contributor Author

馃殌

@florimondmanca
florimondmanca merged commit 2e91d8c into master Aug 21, 2019
@florimondmanca
florimondmanca deleted the refactor/base-event branch August 21, 2019 07:02
@florimondmanca florimondmanca mentioned this pull request Aug 21, 2019
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovelydinosaur lovelydinosaur lovelydinosaur approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@florimondmanca @lovelydinosaur