You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Should BaseTCPStream.is_connection_dropped be async? #356
It looks like #346 was closed, deciding the current implementation is good enough for now with some great research, but it sounds like you may want to improve this API in the future in a way that might require blocking. Given you're pre-1.0 it would be good to get the APIs solid on what can eventually be async before 1.0 so you can more easily use a blocking implementation in the future.
I'm new here and just poking around so please LMK if there's any context I'm missing!
changed the title [-]`BaseTCPStream.is_connection_dropped` should be async[/-][+]Should `BaseTCPStream.is_connection_dropped` be async?[/+]on Sep 18, 2019
Activity
[-]`BaseTCPStream.is_connection_dropped` should be async[/-][+]Should `BaseTCPStream.is_connection_dropped` be async?[/+]florimondmanca commentedon Sep 18, 2019
Interesting point! The fact that trio.hazmat.wait_readable() is async too seems to support this. :)
Please do! Questions and suggestions from fresh eyes are invaluable. 🙌
sethmlarson commentedon Sep 21, 2019
Deferring these changes until we need them, thanks @rowillia! ❤️