Repository navigation
Close all outstanding responses on client close #35
Description
Client close currently closes off any keep-alive connections.
Actually the behavior would be more neatly bounded if we forcibly close off all connections.
with SyncClient() as client:
response = client.get(..., stream=True)
response.read() # This should raise an error.
Activity
jhtimmins commentedon Oct 8, 2019
@florimondmanca is this still up for grabs? And if so, would it make a good first issue?
florimondmanca commentedon Oct 8, 2019
Hi @jhtimmins! There's already a PR for this over at #322, but unfortunately it seems to have slipped through.
So feel free to take it up. I don't think the fix will be trivial, but you can take a crack at it and see where you end up. :)
jhtimmins commentedon Oct 9, 2019
Thanks @florimondmanca! Sounds great. I'll do that.
lovelydinosaur commentedon Dec 16, 2019
Obsoleted by the more tightly bounded
stream()API. (Which ensures that connections can only be held open within astream()context block)