Repository navigation
Stash checksum and/or timestamp in Redis #37
Description
Similar to #25, it would be fantastic if ember-deploy-redis would also stash a checksum (or the commit SHA) and/or a build date/time (or the commit timestamp) of the index to use in the the ETag and Last-Modified HTTP headers. Something like:
foo:index:current => '<!DOCTYPE html>...'
foo:index:current:meta => checksum '787b3dd284fd99202adfa4e18a28126d159552c5'
timestamp 'Wed Sep 16 19:28:37 2015 +0200'
And then...
require 'sinatra'
require 'redis'
get '/' do
content_type 'text/html'
expires 3_600, :public
redis = Redis.new
index_key = redis.get("foo:current")
index_key = "foo:#{params[:index_key]}" if params[:index_key]
meta = redis.hgetall("#{index_key}:meta")
etag meta[:checksum]
last_modified meta[:timestamp]
redis.get(index_key)
endStashing the content in the same hash as the metadata would be ideal (to limit the Redis hits) but would break backwards compatibility.
Activity
achambers commentedon Oct 1, 2015
Thanks for the suggestion @mwpastore. As you can see from the issue you referenced, this is something we've been thinking about. This will also require a change to the ember-cli-deploy/ember-cli-deploy-revision-data repo which is designed to retrieve all that sort of meta data info. Then it will be up to the redis plugin to upload it.
Thanks for the suggestion, we'll look in to it.
As always, PR's are always welcome 👍
mwpastore commentedon Oct 1, 2015
I suspect that it would be way above my skill level, after reviewing both components last night, but I will certainly give it a try. Thanks @achambers!
mwpastore commentedon Oct 1, 2015
Duh, we can just use the
revisionKeyas the ETag, and thetimestampis already being delivered byember-cli-deploy-revision-data, so this should be easier than I thought...
achambers commentedon Oct 1, 2015
Perfect