Repository navigation
build: use yarn@v4 and migrate to vitest - #371
Merged
Merged
Conversation
MarshallOfSound
force-pushed
the
sam/test-yarn4
branch
from
August 4, 2025 03:05
89be1e7 to
818d78c
Compare
MarshallOfSound
marked this pull request as ready for review
August 4, 2025 03:06
MarshallOfSound
changed the title
dsanders11
reviewed
Aug 4, 2025
dsanders11
left a comment
dsanders11
left a comment
Member
There was a problem hiding this comment.
cc @mmaietta as he has an earlier draft PR to migrate to Vitest which was blocked by the Node.js 22 bump. Would be good to make sure the two PRs more or less converged on the same end result.
This would be our first repo to venture off of yarn@v1 to yarn@v4. If that's needed to make the Socket security stuff work, sounds like we'd want to migrate most of our repos. Let's put it on the agenda to discuss at the Ecosystem WG meeting this week.
erickzhao
approved these changes
Aug 14, 2025
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to (a) fix socket dev dependency recognition and (b) make the tests not use deprecated / ancient mocha modules