Repository navigation
Stop Impact and Action extraction at any heading - #4637
Open
theletterf wants to merge 1 commit into
Open
theletterf wants to merge 1 commit into
theletterf wants to merge 1 commit into
Conversation
A heading section used to run until the next heading of the same or a higher level. The Kibana PR template puts `### Checklist` and `### Identify risks` after the author's `## Action`, so every Kibana entry with an Action carried the template into its `action` field. Related to elastic/docs-eng-team#984 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RyiyHmDHcUFt8rjMNR8TBm
![infra-vault-gh-plugin-prod[bot]](https://avatars.githubusercontent.com/u/6764390?s=60&v=4){kind=small}
Member
Author
|
@Mpdreamz This should be fixed. |
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4637/ Sample changed pages: |
Mpdreamz
approved these changes
Oct 29, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impact and Action sections scraped from a PR body now end at the next heading of any level. The Kibana PR template's
### Checklistand### Identify risksblocks no longer ride along inside an entry'sactionfield.Affects: Release notes
Prompt summary: Stop the Impact and Action extraction from swallowing the PR template that follows them. The 2026-10-29 Kibana serverless bundle published a contributor checklist and an internal risk assessment as customer guidance, and the bundler should carry only the prose the author wrote under those headings.
Why
ReleaseNotesExtractor.FindSectionreads a heading section until the next heading of the same or a higher level. The Kibana PR template puts### Checklist,### Identify risksand a generated-by footer after the author's## Action, so every Kibana PR with an Action section drags that template into its entry. In elastic/docs-internal-workflows#1143 the entry for elastic/kibana#299837 published about 2,800 characters of checklist, backport instructions and risk notes as itsaction. Libra flagged it and the field was trimmed by hand.What
Section boundary
A heading of any level now ends an Impact or Action section. The deeper-heading exemption is gone: a
###after a## Actionis the next section, not a child of it. Fenced code blocks and the cross-stop between Impact and Action behave as before.Reference docs
The
evaluate-prpage states the new boundary: a section under a heading runs until the next heading of any level, so notes that are not part of Impact or Action belong under their own heading.Regression test
A test rebuilds the shape of elastic/kibana#299837:
## Impact,## Actionwith bullets, then the template's###sections and footer. It asserts the action ends after the author's last bullet. It fails on the previous code.Verify
Out of scope: a footer that follows an Action section with no heading between them, such as a generated-by line, still becomes part of the section.
Related to https://github.com/elastic/docs-eng-team/issues/984
🤖 Generated with Claude Code
https://claude.ai/code/session_01RyiyHmDHcUFt8rjMNR8TBm