Repository navigation
Conversation
A retry with no data puts the query back in `pending`, so `isLoading` already covers it, and with `keepPreviousData` the retry has placeholder data. `isFetching && !data` never changed `loading`, and its comment said the opposite. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
trivikr
force-pushed
the
webui-extension-list-loading-check
branch
from
October 29, 2026 00:45
ac98d02 to
c4678a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
(isFetching && !data)fromExtensionList'sloading, along with its comment. The comment claimed a retry after a failed first page isn'tisLoading, which isn't true in TanStack Query v5:pending, soisLoadingis true.keepPreviousDatashows the previous results as placeholder data during the retry, sodatais defined.This matches the same change made for the curated home rows in #2365 (comment)
No behaviour change, so no new test or changelog entry.