Repository navigation
feat(webui): tidy public exports and add hooks - #2333
Merged
Merged
Conversation
gnugomez
marked this pull request as draft
October 14, 2026 11:47
gnugomez
marked this pull request as ready for review
October 14, 2026 11:48
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The public API rewrite lacks the repository-required package-root contract test.
1 open finding
What changed in this PR
Refines the web UI package’s public API and exports reusable hooks while documenting breaking removals.
Changes:
- Reorganizes explicit package-root exports and adds three hooks.
- Removes accidentally exposed internals.
- Removes the React type resolution and deduplicates
csstype.
| File | Description |
|---|---|
webui/src/index.ts |
Defines the revised public API. |
webui/package.json |
Removes the React type resolution. |
webui/yarn.lock |
Updates React types and deduplicates csstype. |
webui/CHANGELOG.md |
Documents additions and breaking removals. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
netomi
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups the
index.tsexports by area and uses named exports, so the published surface is explicit.Also exports hooks that consumers would otherwise rewrite themselves:
useInView(withViewportObserverContextfor tests),useRegistryValueanduseReportedQuery.Breaking: stops exporting
SearchActionContext,filterFromParams,filterToParams,SEARCH_DEBOUNCE_MSandExtensionHeaderInfo, which were exposed by accident throughexport *.Also drops the
@types/reactresolution left over from #2321, dedupingcsstypeso the types build passes without it.