Repository navigation
fix: TP: store extra information - #2283
Merged
Merged
Conversation
Added code to optionally (if present) record extra information about trusted publishing claim verification: - GitHub: job_workflow_ref, run_id, workflow_sha - GitLab: pipeline_id, job_id, sha Closes #2116
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
GitHub provenance records workflow_sha but omits the required source commit sha.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Extends trusted-publishing provenance with optional workflow-run metadata.
Changes:
- Records GitHub and GitLab run identifiers and commit metadata.
- Tests extraction and matching behavior with optional claims.
| File | Description |
|---|---|
GitLabTrustedPublishingProviderTest.java |
Tests optional GitLab provenance claims. |
GitHubTrustedPublishingProviderTest.java |
Tests optional GitHub provenance claims. |
GitLabTrustedPublishingProvider.java |
Extracts pipeline, job, and commit identifiers. |
GitHubTrustedPublishingProviderSupport.java |
Extracts workflow and run identifiers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The property is not clearly documented but multiple sources suggests is used. So using it and we will test it.
netomi
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to optionally (if present) record extra information about trusted publishing claim verification:
Closes #2116