Repository navigation
chore: add a Makefile for common development tasks - #2144
Merged
Merged
Conversation
Three targets for the three things a local setup needs running, meant for three terminals: `dev-env` holds the containers, `server` and `webui` run the two applications against them. `dev-env` starts postgres, the valkey cluster with its admin UI and minio. Elasticsearch is left out on purpose - the dev profile searches the database instead. `dev-env-down` removes those containers again. `make` on its own lists the targets, so the file documents itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The webui target’s install command is inconsistent with the repo’s compose-based workflow and can unintentionally modify the lockfile; aligning it will reduce surprises.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a root-level Makefile to standardize common local development workflows (starting required containers, running the server, and running the web UI) with a self-documenting make help default target.
Changes:
- Add
dev-env/dev-env-downtargets to run docker-compose with a sharedDEV_PROFILESlist. - Add
serverandwebuitargets to run the backend and frontend locally. - Add a
helptarget and set it as the default goal to list available targets from##comments.
File summaries
| File | Description |
|---|---|
| Makefile | Introduces Make targets for dev containers, server, and web UI plus an auto-generated help listing. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Thomas Neidhart <thomas.neidhart@gmail.com>
cstamas
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a root
Makefilewith the three things a local setup needs running. They are meant for three terminals:dev-envholds the containers,serverandwebuirun the two applications against them and stay in the foreground so they pick up code changes.Targets
dev-envdocker compose --profile db --profile valkey --profile valkey-admin --profile minio updev-env-downdownservercd server && ./scripts/generate-properties.sh && ./gradlew runServerwebuicd webui && yarn install && yarn devNotes on the two that are not a single command:
serverrunsgenerate-properties.shfirst becauserunServerneedsapplication-ovsx.propertiesto exist. The script exits early when it is already there, so it costs nothing on repeat runs.webuirunsyarn installfirst, mirroring what the composewebuiservice already does (yarn install --immutable && yarn dev).The profile list lives in one
DEV_PROFILESvariable rather than being repeated across the two compose targets, andmakewith no argument prints the target list, parsed from the##comments so it cannot drift from the targets themselves.Elasticsearch is deliberately not in the profile set — the dev profile searches the database (
ovsx.databasesearch.enabled: true,ovsx.elasticsearch.enabled: false), so the server runs fine without it. There is a comment in the file saying so, since its absence otherwise looks like an oversight.Worth knowing when using this:
ovsx.redis.enabledisfalseand storage defaults tolocalin the dev profile, so valkey and minio start but the server does not talk to them until the corresponding blocks inserver/src/dev/resources/application.ymlare uncommented.Testing
Each target was run for real, not just written:
make dev-env— all 9 containers up and healthy (postgres, 6 valkey nodes, valkey-admin, minio).make server— reachedStarted RegistryApplication, Jetty on 8080,GET /api/-/searchreturned 200.make webui— vite serving on 3000,GET /returned 200.make dev-env-down— removed every container and the network, leaving a cleangit status.🤖 Generated with Claude Code