Repository navigation
chore: remove unused methods from RepositoryService - #2117
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes several unused query/delete methods from RepositoryService and various Spring Data repository interfaces, and updates the repository smoke test to stop exercising the removed APIs.
Changes:
- Removed unused
RepositoryServicemethods related to personal access tokens, validation failures, and admin scan decisions. - Removed unused Spring Data repository methods (e.g.,
findAll,deleteById, and several scan/threat query helpers). - Updated
RepositoryServiceSmokeTestto no longer call the removed methods.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/test/java/org/eclipse/openvsx/repositories/RepositoryServiceSmokeTest.java | Removes calls to RepositoryService methods that no longer exist. |
| server/src/main/java/org/eclipse/openvsx/repositories/RepositoryService.java | Deletes unused service-layer wrapper methods. |
| server/src/main/java/org/eclipse/openvsx/repositories/RateLimitTokenRepository.java | Removes unused findByCustomer(Customer) repository method. |
| server/src/main/java/org/eclipse/openvsx/repositories/PersonalAccessTokenRepository.java | Removes unused findAll() repository method. |
| server/src/main/java/org/eclipse/openvsx/repositories/NamespaceMembershipRepository.java | Removes unused deleteByUser(UserData) repository method. |
| server/src/main/java/org/eclipse/openvsx/repositories/ExtensionValidationFailureRepository.java | Removes unused deleteById(long) repository method. |
| server/src/main/java/org/eclipse/openvsx/repositories/ExtensionThreatRepository.java | Removes unused threat lookup helpers and deleteById(long). |
| server/src/main/java/org/eclipse/openvsx/repositories/ExtensionScanRepository.java | Removes unused findByNamespaceName(String) repository method. |
| server/src/main/java/org/eclipse/openvsx/repositories/AdminScanDecisionRepository.java | Removes unused deleteById(long) repository method. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.