Skip to content

chore: remove unused methods from RepositoryService - #2117

Merged
netomi merged 4 commits into
mainfrom
chore/cleanup
Sep 1, 2026
Merged

netomi merged 4 commits into
mainfrom
chore/cleanup

Conversation

@netomi

@netomi netomi commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@netomi
netomi requested a lite review from Copilot September 1, 2026 17:29
@netomi netomi changed the title chore: remove unused method from RepositoryService chore: remove unused methods from RepositoryService Sep 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes several unused query/delete methods from RepositoryService and various Spring Data repository interfaces, and updates the repository smoke test to stop exercising the removed APIs.

Changes:

  • Removed unused RepositoryService methods related to personal access tokens, validation failures, and admin scan decisions.
  • Removed unused Spring Data repository methods (e.g., findAll, deleteById, and several scan/threat query helpers).
  • Updated RepositoryServiceSmokeTest to no longer call the removed methods.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
server/src/test/java/org/eclipse/openvsx/repositories/RepositoryServiceSmokeTest.java Removes calls to RepositoryService methods that no longer exist.
server/src/main/java/org/eclipse/openvsx/repositories/RepositoryService.java Deletes unused service-layer wrapper methods.
server/src/main/java/org/eclipse/openvsx/repositories/RateLimitTokenRepository.java Removes unused findByCustomer(Customer) repository method.
server/src/main/java/org/eclipse/openvsx/repositories/PersonalAccessTokenRepository.java Removes unused findAll() repository method.
server/src/main/java/org/eclipse/openvsx/repositories/NamespaceMembershipRepository.java Removes unused deleteByUser(UserData) repository method.
server/src/main/java/org/eclipse/openvsx/repositories/ExtensionValidationFailureRepository.java Removes unused deleteById(long) repository method.
server/src/main/java/org/eclipse/openvsx/repositories/ExtensionThreatRepository.java Removes unused threat lookup helpers and deleteById(long).
server/src/main/java/org/eclipse/openvsx/repositories/ExtensionScanRepository.java Removes unused findByNamespaceName(String) repository method.
server/src/main/java/org/eclipse/openvsx/repositories/AdminScanDecisionRepository.java Removes unused deleteById(long) repository method.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@netomi
netomi merged commit 792e5d0 into main Sep 1, 2026
5 checks passed
@netomi
netomi deleted the chore/cleanup branch September 1, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants