Repository navigation
Conversation
netomi
reviewed
Aug 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Web UI’s extension detail overview layout to remove the “intermediate/tablet” sidebar state, aiming for only two responsive modes: mobile (stacked) and desktop (two-column), addressing layout issues reported in #2068.
Changes:
- Simplifies the main layout breakpoint logic to switch to a two-column layout starting at
md(instead of only atxl). - Makes the sidebar content consistently stack vertically (rows) instead of switching to a multi-column/row layout at some breakpoints.
- Adds spacing via flex
gapto replace some prior breakpoint-specific spacing logic.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…akpoint
resourcesGroup's own mb: { xs: 2, sm: 2, md: 0, lg: 0, xl: 2 } was a
leftover from when the sidebar groups were laid out in a row at
md/lg (no vertical margin needed there). Now that the sidebar is
unconditionally a column at every breakpoint, that split meant md/lg
groups got only the parent's gap: 2 (16px) while xs/sm/xl groups got
gap: 2 plus their own mb: 2 stacked on top (32px) - reintroducing the
same tablet-vs-desktop inconsistency this PR removes elsewhere.
Drop mb entirely and let the parent's gap: 2 be the sole source of
spacing between groups, consistently at every breakpoint.
Refs eclipse-openvsx#2068
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
netomi
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes #2068 by removing the intermediate state of the sidebar, now there's only two possibilities, mobile or desktop, not tablet, for tablet the sidebar would remain as in desktop.