Skip to content

Add system language option to language selection - #2307

Open
habacksill wants to merge 4 commits into
ebkr:developfrom
habacksill:feature/system-language
Open

habacksill wants to merge 4 commits into
ebkr:developfrom
habacksill:feature/system-language

Conversation

@habacksill

Copy link
Copy Markdown
Contributor

Changes

Added a System option to the language selection menu.

When System is selected, the application detects the operating system's preferred language and automatically selects the first supported language.

If none of the preferred system languages are supported, the application falls back to English (en).

New installations will also use System as the default language.

Testing

The Korean translation files from #2294 have been merged into this branch for testing purposes.

This allowed the System language detection and language selection behavior to be tested with Korean included as a supported language.

On a Korean Windows environment, selecting System correctly detects and applies Korean (ko).

@ebkr

ebkr commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Very good idea, thank you!

I'll be looking at finding some time to review all of the language PRs in the very near future! Apologies for the delay with it.

@ebkr

ebkr commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

@habacksill Would you be able to rebase this onto #2309

This PR adds better support for when there's a large language list, which has what's really been the blocker to getting any of these merged.

@habacksill
habacksill force-pushed the feature/system-language branch from 7818707 to 3f9abd3 Compare October 21, 2026 12:10
@habacksill

habacksill commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor Author

I rebased to #2309
Check this pls if there is something wrong. It worked well in my end.

@ebkr

ebkr commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

I merged lang-main with text fixes and now there's conflicts 💀

On the flip side, the KO translation changes are now on develop 🔥

@habacksill

Copy link
Copy Markdown
Contributor Author

Oh, got it
Is there anything I can do to help resolve the conflicts, or are you planning to handle the fixes yourself?

@ebkr

ebkr commented Oct 27, 2026

Copy link
Copy Markdown
Owner

You'd just need to rebase back onto develop again this time

Add a System selection to the Language.
It will detect the device lang and apply it.
If r2modman don't support that lang, it will show English by default.
Show "System" words in UI at every lang properly
It was test.
Rebased to ebkr#2309

1. Added a System language option to the language selection overlay.
2. Enabled searching for the System option by its identifier or translated name.
3. Updated language selection to emit a `select-locale` event instead of saving the locale directly in `SelectOverlay.vue`.
4. Connected the selection event to `App.vue` to save the selected locale and update the current selection.
5. Preserved the existing language search functionality introduced by the `i18n-see-more-modal` changes.
@habacksill
habacksill force-pushed the feature/system-language branch from 3f9abd3 to 4a2f55e Compare October 27, 2026 17:35
@habacksill

Copy link
Copy Markdown
Contributor Author

I've rebased my branch onto upstream/develop and force-pushed it.
There were a few conflicts, which I resolved. Could you please check if anything looks wrong?
I tested it and everything worked as expected on my end. (maybe...)

@habacksill

Copy link
Copy Markdown
Contributor Author

oh there is a little typecheck failure because Chinese .ts doesn't have "System" trans target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants