Repository navigation
Devcontainer 4/6: vendored Nek5000 cases and DEC core, nek5000 feature - #343
Open
ludgerpaehler wants to merge 1 commit into
Open
ludgerpaehler wants to merge 1 commit into
ludgerpaehler wants to merge 1 commit into
Conversation
Split out of #266 (Devcontainer update), fourth step. Adds: - third_party/nek5000/cases/{mini_channel,large_channel,naca0012_200k, small_wing}: case sources for the Nek5000 cases HydroGym ships on the Hub (TCFmini_3D_Re180, TCFlarge_3D_Re206/207, NACA0012_3D_Re200000_AOA0, NACA4412_3D_Re75000_AOA5), including the makefile_usr.inc / Toolbox object-name fixes from #266. - third_party/nek5000/solver/DEC_DRL_Nek5000: the older, self-contained Nek5000 core the two airfoil cases' compile_script builds against (tracked directly, not a submodule). - features/nek5000 and the nek5000-test config: builds the requested cases' nek5000 binaries at container start and installs hydrogym[nek] into /opt/venvs/nek5000. - pyproject.toml: exclude third_party from ruff, isort and codespell; none of it is code we maintain. - third_party/nek5000/README.md: layout of this tree. The feature script referred to a DEC_DRL_Nek5000/VENDORED_README.md that #266 never added; it now points here. Relative to #266: the six *.map files are stored in Git LFS (the naca0012_200k one is 24 MB and would otherwise sit in history as a plain blob), and three Emacs backup files (#oppo_ctrl.f#, #time_series.f#, time_series.f~) are dropped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes the vendored Nek5000 part of #266 (Devcontainer update). Part 4 of 6; stacked on #342.
What
third_party/nek5000/cases/{mini_channel,large_channel,naca0012_200k,small_wing}: case sources for the Hub environmentsTCFmini_3D_Re180,TCFlarge_3D_Re206/207,NACA0012_3D_Re200000_AOA0andNACA4412_3D_Re75000_AOA5, including themakefile_usr.inc/ Toolbox object-name fixes from Devcontainer update #266.third_party/nek5000/solver/DEC_DRL_Nek5000: the older, self-contained Nek5000 core that the two airfoil cases'compile_scriptbuilds against (591 files, 9.4 MB, tracked directly rather than as a submodule; the channel cases use the KTH submodule core from part 1).features/nek5000and thenek5000-testconfig: builds the requested cases'nek5000binaries at container start and installshydrogym[nek]into/opt/venvs/nek5000.pyproject.toml:third_partyexcluded from ruff, isort and codespell; none of it is code HydroGym maintains.third_party/nek5000/README.md: layout of the tree (which parts are submodules, which are vendored, which Hub environment each case corresponds to, and how each flavour is built). The feature script referred to aDEC_DRL_Nek5000/VENDORED_README.mdthat Devcontainer update #266 did not include; it now points at this README.Changes relative to #266
*.mapfiles are stored in Git LFS (naca_wing.mapis 24 MB). The LFS objects are uploaded;git lfs ls-fileson this branch lists 18 files, all present.cases/naca0012_200k(#oppo_ctrl.f#,#time_series.f#,time_series.f~) are not carried over.HYDROGYM_ENGINEERING_AUDIT_v2.md, which belongs to Audit Phase 0: CI safety net #283.Verification
Lint, lockfile and syntax checks as in the earlier parts, with ruff/isort confirmed to skip
third_party. Not built locally.🤖 Generated with Claude Code