Skip to content

coffeescript #19

Open
Open

Description

@dudo

My coding style:
I like braces and use them always, even for single-line if statements and the like.

Granted... but you did implement jade, so you can appreciate indented style. Any thoughts about handling coffeescript?

Activity

  1. dstroot commented on Jul 8, 2014

    @dstroot
    Owner

    I love Jade because of how it takes away a lot of the HTML 'cruft' and I find Jade really easy to follow. I definitely see the analogy to coffeescript. I have looked at coffeescript several times. However for whatever reason I haven't had the same feelings for coffeescript. I "had to" pick one of the HTML templating tools and I happened to choose Jade but I haven't felt I had to use a tool like coffeescript. By keeping this in pure JS I feel it's maybe more accessible to a wider audience.

    Long way of saying I guess I'm just not that familiar with coffescript.

  2. dudo commented on Jul 8, 2014

    @dudo
    Author

    Makes sense. I'll work on adding support for it, while keeping the system files in pure JS. We just have to add coffee-script as a dependency, and gulp-coffee to devdependencies. A little snippet, and maybe a linter, and users will be able to use coffeescript for their projects.

    I'll holler when I have a PR ready.

  3. dstroot commented on Jul 8, 2014

    @dstroot
    Owner

    Awesome - that would be really helpful. Maybe even encourage me to give it an honest try ;)

  4. dudo commented on Jul 11, 2014

    @dudo
    Author

    Hey Dan. I have a PR ready for the coffeescript integration. You wanna give me permission to push a branch?

    I made the appropriate changes, but also converted 2 files to .coffee as working examples:

    • user.coffee controller
    • User.coffee model

    I set $.coffee to compile to public/js... might consider tucking that away (compiled dir or something, then we can ignore it from linting?)

    We can chat a bit after you take a look at it, and see it in action.

  5. dstroot commented on Jul 12, 2014

    @dstroot
    Owner

    As far as I know I don't need to give permission - just open a pull request. That's how I have done it on other repos. Looking forward to checking it out!

  6. dudo commented on Jul 12, 2014

    @dudo
    Author
    Pushing to git@github.com:dstroot/skeleton.git
    ERROR: Permission to dstroot/skeleton.git denied to dudo.
    fatal: Could not read from remote repository.
    
    Please make sure you have the correct access rights
    and the repository exists.
    

    I'm only pushing my coffee branch, too... not master. I can pull fine... just can't seem to push.

  7. dudo commented on Jul 12, 2014

    @dudo
    Author

    might have to add me as a collaborator in settings.

    screen shot 2014-07-11 at 9 16 25 pm

  8. dstroot commented on Jul 13, 2014

    @dstroot
    Owner

    Have you tried opening a pull request? Generally contributors don't push, the owner pulls. At least thats how it's worked on other repos I have contributed to. You open a pull request with the changes in your fork. I review them and pull them in.

    image

  9. dstroot commented on Jul 17, 2014

    @dstroot
    Owner

    You give up on me? ;)

  10. dudo commented on Jul 17, 2014

    @dudo
    Author

    Haha, no. I'm used to bitbucket, I guess. You just push a branch up, then submit the PR. I'll figure it out here soon... I've been playing a bit more with ReactJS lately. I'll get this pushed up tomorrow, though =)

    Cheers!

  11. dstroot commented on Jul 17, 2014

    @dstroot
    Owner

    React is damn cool - I played with it a bit too. It's just pretty "different" so you really have to commit to it I think rather than just dabble...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions