Skip to content

production.default.props does not resolve #1

Open

Description

@tuhlmann

Hi David,

I'm using Dragonmark Utils in my Clojure side project (the get a bit of Lift feeling :) ).

The doc string says production.default.props would resolve as the default production property file. However that would only resolve if I set -Drun.mode=production, but this isn't recognized as production run mode.

To make it work I set -Drun.mode=prod and name the file prod.default.props.

To make it consistent, either the documentation should be adapted or :production be added to the run modes that trigger production-mode?

You want a pull request?

Activity

  1. dpp commented on Mar 12, 2016

    @dpp
    Member

    👍 on a PR!

  2. tuhlmann commented on Mar 12, 2016

    @tuhlmann
    ContributorAuthor

    @dpp Which way do you wanna go?

    • Change documentation
    • Allow :production along with :prod
    • Replace :prod with :production
  3. dpp commented on Mar 12, 2016

    @dpp
    Member

    Have prop == production and update the docs indicating that either is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions