Repository navigation
Replace NetFrameworkMinimum with NetFrameworkToolCurrent in TemplateEngine projects - #53966
Merged
Merged
Conversation
…ngine projects Agent-Logs-Url: https://github.com/dotnet/sdk/sessions/04692118-5593-4e69-94c6-7681a7a85db5 Co-authored-by: MichaelSimons <8290530+MichaelSimons@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates TemplateEngine projects to target the canonical Arcade-provided .NET Framework tool TFM property ($(NetFrameworkToolCurrent)) instead of relying on a local $(NetFrameworkMinimum) override, keeping the effective netfx target unchanged while removing the workaround.
Changes:
- Removed the
NetFrameworkMinimum=net472override (and associated TODO) from TemplateEngineDirectory.Build.propsfiles insrc/andtest/. - Switched TemplateEngine project
TargetFrameworksfrom$(NetFrameworkMinimum)to$(NetFrameworkToolCurrent)across the affected src projects. - Updated the TemplateEngine test helper shared props to use
$(NetFrameworkToolCurrent).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/TemplateEngine/Microsoft.TemplateEngine.TestHelper/Microsoft.TemplateEngine.TestHelper.Shared.props | Updates TestHelper multi-targeting to use $(NetFrameworkToolCurrent) for the netfx leg. |
| test/TemplateEngine/Directory.Build.props | Removes the local NetFrameworkMinimum override now that projects no longer depend on it. |
| src/TemplateEngine/Tools/Microsoft.TemplateEngine.TemplateLocalizer.Core/Microsoft.TemplateEngine.TemplateLocalizer.Core.csproj | Switches netfx target in TargetFrameworks to $(NetFrameworkToolCurrent). |
| src/TemplateEngine/Microsoft.TemplateSearch.Common/Microsoft.TemplateSearch.Common.csproj | Switches netfx target in TargetFrameworks to $(NetFrameworkToolCurrent). |
| src/TemplateEngine/Microsoft.TemplateEngine.Utils/Microsoft.TemplateEngine.Utils.csproj | Switches netfx target in TargetFrameworks to $(NetFrameworkToolCurrent). |
| src/TemplateEngine/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/Microsoft.TemplateEngine.Orchestrator.RunnableProjects.csproj | Switches netfx target in TargetFrameworks to $(NetFrameworkToolCurrent). |
| src/TemplateEngine/Microsoft.TemplateEngine.IDE/Microsoft.TemplateEngine.IDE.csproj | Switches netfx target in TargetFrameworks to $(NetFrameworkToolCurrent). |
| src/TemplateEngine/Microsoft.TemplateEngine.Edge/Microsoft.TemplateEngine.Edge.csproj | Switches netfx target in TargetFrameworks to $(NetFrameworkToolCurrent). |
| src/TemplateEngine/Microsoft.TemplateEngine.Core/Microsoft.TemplateEngine.Core.csproj | Switches netfx target in TargetFrameworks to $(NetFrameworkToolCurrent). |
| src/TemplateEngine/Microsoft.TemplateEngine.Core.Contracts/Microsoft.TemplateEngine.Core.Contracts.csproj | Switches netfx target in TargetFrameworks to $(NetFrameworkToolCurrent). |
| src/TemplateEngine/Microsoft.TemplateEngine.Abstractions/Microsoft.TemplateEngine.Abstractions.csproj | Switches netfx target in TargetFrameworks to $(NetFrameworkToolCurrent). |
| src/TemplateEngine/Directory.Build.props | Removes the local NetFrameworkMinimum override now that projects no longer depend on it. |
NikolaMilosavljevic
approved these changes
Apr 17, 2026
Member
|
/ba-g unrelated test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the NetFX TFM TODO comments in
src/TemplateEngine/Directory.Build.propsandtest/TemplateEngine/Directory.Build.props(dotnet/templating#10085).Summary
All TemplateEngine projects were using a
$(NetFrameworkMinimum)override pinned tonet472in the localDirectory.Build.propsfiles to work around the Arcade SDK default ofnet462. This changes them to use$(NetFrameworkToolCurrent)— the canonical property used by all other SDK tool projects — and removes the now-unnecessary override.The effective .NET Framework TFM is unchanged (
net472 = NetFrameworkToolCurrentin the Arcade SDK).Changes
<NetFrameworkMinimum>net472</NetFrameworkMinimum>override and TODO comment fromsrc/TemplateEngine/Directory.Build.props<NetFrameworkMinimum>net472</NetFrameworkMinimum>override and TODO comment fromtest/TemplateEngine/Directory.Build.propsTargetFrameworksin 9src/TemplateEnginelibrary.csprojfiles:$(NetFrameworkMinimum)→$(NetFrameworkToolCurrent)test/TemplateEngine/Microsoft.TemplateEngine.TestHelper/Microsoft.TemplateEngine.TestHelper.Shared.propssimilarlyVerification
All
src/TemplateEngineprojects build cleanly. Template engine unit tests pass.