Repository navigation
Unskip test case - #50031
Merged
nagilson merged 1 commit intoAug 4, 2025
Merged
Unskip test case#50031
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR unskips a previously disabled test case by removing the Skip parameter from an InlineData attribute. The test was originally skipped due to a GitHub issue (#49926) but is now being re-enabled.
- Removed the Skip parameter from one InlineData test case
- Re-enabled testing of the scenario with
specifyRid=trueandsingleFile=true
| [Theory] | ||
| [InlineData(true, false)] | ||
| [InlineData(true, true, Skip = "https://github.com/dotnet/sdk/issues/49926")] | ||
| [InlineData(true, true)] |
There was a problem hiding this comment.
When unskipping a test that was previously disabled due to an issue, it's important to verify that the underlying issue (#49926) has been resolved. Consider adding a comment or updating the commit message to indicate why this test is now safe to run.
nagilson
approved these changes
Aug 4, 2025
MiYanni
approved these changes
Aug 4, 2025
nagilson
deleted the
Simon/Unskip_testcase_RunPublishItemsOutputGroupOutputsTest
branch
August 4, 2025 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable the test case: RunPublishItemsOutputGroupOutputsTest(specifyRid: true, singleFile: true)