Repository navigation
[workloads] Add new workloads for net8.0 - #75200
Merged
Merged
Conversation
ghost
added
the
Member
Author
|
Net8 workloads still won't really work in wbt until there is a proper net8 sdk without another hack |
lewing
changed the title
Member
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run runtime-wasm-perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…, and need net7 worklaod
…dotnet#75274)" This reverts commit fce39ad.
lewing
commented
Sep 9, 2022
lewing
left a comment
lewing
left a comment
Member
Author
There was a problem hiding this comment.
the autoimport stuff can't work this way
… 7.0 branch gets the fix for forwardConsole arg being renamed
This reverts commit 1b05102.
- this was failing because the test added reference to a function `withExitOnUnhandledError()` to `main.js`, which is available only in 8.0 . But the tests are still running with wasm-tools-net7, and tfm=net7.0 .
Member
|
/azp run runtime-wasm-perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was generated part of some nugets to fix file permissions because it wasn't supported by nuget. But that is fixed now, stop generating the file, and remove the corresponding tests.
radical
approved these changes
Sep 10, 2022
Member
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
|
Member
|
All the failures are unrelated. Merging this, which will also unblock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport the workload changes from net7 but and a versionless manifest that represents the netappcurrent so that version bumps will require fewer immediate changes in net9.0
Wasm.Build.Testsinstallswasm-tools, andwasm-tools-net7wasm-tools, andwasm-tools-net7for running, with projects built fornet7.0net6.0workload install is attempted, but fails because the6.0.10package isn't on public feeds yet