Repository navigation
[metadata] Do less initialization in mono_class_is_assignable - #73786
Merged
Merged
Conversation
Instead of running the full mono_class_init_internal, just initialize the supertypes and the interface bitmap. Add a flag to mono_class_setup_interface_offsets to only publish the interface bitmap, not the offsets. Also move the SRE hack (setting a field in MonoClass to null and running mono_class_setup_interface_offsets) to a new function mono_class_invalidate_interface_offsets. Also change the field that the SRE hack uses as a sentinel (used to be MonoClass:interfaces_packed, now MonoClass:interface_offsets_packed) Fixes dotnet#68033
This comment was marked as outdated.
This comment was marked as outdated.
lambdageek
marked this pull request as ready for review
August 12, 2022 20:02
lambdageek
force-pushed
the
hack-gh-68033
branch
from
August 12, 2022 20:05
2fb19ce to
066cc8c
Compare
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of running the full mono_class_init_internal, just initialize
the supertypes and the interface bitmap.
Add a flag to mono_class_setup_interface_offsets to only publish the
interface bitmap, not the offsets.
Also move the SRE hack (setting a field in MonoClass to null and
running mono_class_setup_interface_offsets) to a new function
mono_class_invalidate_interface_offsets.
Also change the field that the SRE hack uses as a sentinel (used to be
MonoClass:interfaces_packed, now MonoClass:interface_offsets_packed)
Fixes #68033