Repository navigation
Conversation
Remove the uncalled GC notification registration methods, callback state, and GetMemoryLoad FCall. Preserve the GC interface for standalone-GC compatibility. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jkotas
requested review from
matyaskollert
and
a balanced review from Copilot
November 4, 2026 06:51
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
@matyaskollert Something that I have noticed when reviewing your change. It seems to be a left-over from an abandoned experiment. |
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the removal of the unused memory-load notification infrastructure.
No open issues 🎉
What changed in this PR
Removes unused CoreCLR memory-load notification infrastructure while retaining the GC interface method for standalone-GC compatibility.
Changes:
- Deletes notification registration, unregistration, callback logic, and associated managed state.
- Removes the managed
GetMemoryLoadinternal call and its native implementation, declaration, and registration. - Marks the preserved
IGCHeap::GetMemoryLoadmethod as currently unused.
| File | Description |
|---|---|
src/coreclr/vm/ecalllist.h |
Removes the GetMemoryLoad FCall registration. |
src/coreclr/vm/comutilnative.h |
Removes the native FCall declaration. |
src/coreclr/vm/comutilnative.cpp |
Removes the native FCall implementation. |
src/coreclr/System.Private.CoreLib/src/System/GC.CoreCLR.cs |
Removes notification methods, callback state, and the managed internal call. |
src/coreclr/gc/gcinterface.h |
Adds an unused-status comment without changing the GC interface. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the uncalled GC notification registration methods, callback state, and GetMemoryLoad FCall. Preserve the GC interface for standalone-GC compatibility.