Repository navigation
Keep volatile indirections of promoted struct fields - #136940
NinoFloris wants to merge 1 commit into
Conversation
|
Azure Pipelines: Successfully started running 5 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
I don't agree. These tests are much too fragile, relying on exact promotion heuristics that are going to be changing in this release. I don't think the test is needed. I would be ok with outerloop test that validates that a volatile load was not dropped by testing for a race. |
FWIW, this used to have quite significant diffs around structs that were later proved to be not exposed. Looks like something changed since the diffs are very minimal now, however. |
Fixes #136936, a longstanding bug that was kept around as a quirk for zero-diffs at the time. Disasm tests here are a bit fragile, though arm has stabilized its instructions around this now, but I'd rather have them than not.