Repository navigation
[release/11.0] Use the interpreter GC decoder when inspecting interpreted frames - #136938
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…36553) <!-- --> ## Summary Use `InterpreterGcInfoDecoder` rather than the target-native `GcInfoDecoder` when inspecting an interpreted frame in: - `SfiNextWorker`, for reverse-P/Invoke detection during exception propagation. - `SafeToReportGenericParamContext`, for the generic-context prolog length. - `FindFirstInterruptiblePoint`, for the GC-reporting location when unwinding between funclets. Interpreter GC metadata has different encoding parameters and normalization from native metadata. Select the decoder using the frame's code manager, guarded by `FEATURE_INTERPRETER`, and preserve the existing decoder for native frames. Found while investigating #135821. This PR is independently based on `main` and contains no Wasm metadata-format or code-generation changes. The decoder mismatch predates that work; an observable release-mode iOS failure has not been demonstrated. ## Validation - `./build.sh clr.runtime -rc Checked` on this standalone branch: passed, zero warnings and errors. - Session-local caught-exception, generic-GC, and uncaught reverse-P/Invoke probes on this standalone branch: passed with normal execution and with `DOTNET_Interpreter='*' DOTNET_ReadyToRun=0`. The uncaught probe terminated as expected and retained `MessageFromMyException`. - On the Wasm metadata branch, the reverse-P/Invoke probe reproduced the missing-message/assertion failure before this fix and preserved the exception message afterward; the checked browser runtime build also passed. This is supplementary evidence, not a standalone-branch browser test. - `git diff upstream/main...HEAD --check`: passed. - No new checked-in regression test; existing `WasmBuildAppTest.ExceptionFromMain` caught the EH regression. - iOS execution and the full test suites were not run. > [!NOTE] > This pull request description and code changes were generated with GitHub Copilot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 798665fd-8e9d-46c8-b56c-843764cdb3d1
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #136553 to release/11.0
/cc @davidwrighton
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.