Skip to content

Correct ReadyToRun virtual override fixup labels - #136931

Open
davidwrighton with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-r2r-signature-formatter-labels
Open

davidwrighton with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-r2r-signature-formatter-labels

Conversation

Copilot AI commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

The ReadyToRun signature formatter labeled Check_VirtualFunctionOverride fixups as VERIFY, misrepresenting their failure behavior.

  • Formatter: Emit CHECK_VIRTUAL_FUNCTION_OVERRIDE for Check fixups; retain VERIFY_VIRTUAL_FUNCTION_OVERRIDE for Verify fixups.
  • Coverage: Add an R2R formatter test covering both labels.
Check_VirtualFunctionOverride  → CHECK_VIRTUAL_FUNCTION_OVERRIDE
Verify_VirtualFunctionOverride → VERIFY_VIRTUAL_FUNCTION_OVERRIDE

@azure-pipelines

azure-pipelines Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Co-authored-by: davidwrighton <10779849+davidwrighton@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix R2R signature formatter labels for Check_VirtualFunctionOverride Correct ReadyToRun virtual override fixup labels Nov 3, 2026
Copilot AI requested a review from davidwrighton November 3, 2026 19:39
@jkotas
jkotas marked this pull request as ready for review November 3, 2026 21:08
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/crossgen-contrib
See info in area-owners.md if you want to be subscribed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

R2R signature formatter labels Check_VirtualFunctionOverride fixups as Verify_VirtualFunctionOverride

4 participants