Repository navigation
[release/10.0] [CoreCLR] Protect exception object across funclet callbacks - #136708
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Fixes #132462 ## Summary - Protect the exception `OBJECTREF` in `CallFilterFunclet` and `CallCatchFunclet` while profiler, debugger, and ETW callbacks may permit GC, through the subsequent funclet invocation. - Extend the existing exception profiler test to exercise both filter and catch funclet paths while exception monitoring is enabled. ## Testing - Confirmed the regression test fail-fasts against the unfixed checked runtime. - Built CoreCLR checked successfully with no warnings or errors. - Ran the targeted `ExceptionTest` against the fixed checked runtime; it returned 100 and reported `PROFILER TEST PASSES`. > [!NOTE] > This description was generated with GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d1145d75-6c1d-4d53-8793-ea41900a04ca Copilot-Session: 6a0f5fb2-4a96-4a7e-8f6a-37bb262a1401
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
github-actions
Bot
added
the
area-ExceptionHandling-coreclr
jkotas
approved these changes
Oct 30, 2026
This was referenced Oct 30, 2026
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #132482 to release/10.0
/cc @janvorli @steveisok
Customer Impact
Application can crash due to a GC hole e.g. with access violation when profiler or debugger is attached to it. The exception object is not correctly protected in the CallCatchFunclet and CallFilterFunclet across a call to notify debugger or profiler on the exception.
Regression
Testing
Targeted regression test, coreclr tests
Risk
Low, the change just moves the exception object extraction to local variable after the problematic callback to debugger / profiler.