Skip to content

Keep invalid type references live in Loader negative tests #136540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewing merged 2 commits into from
Oct 28, 2026
Merged

Keep invalid type references live in Loader negative tests #136540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34cbebe
Keep invalid type references live in Loader negative tests
lewing Oct 27, 2026
1621aeb
Use GC.KeepAlive in InternalMethodImplTest
lewing Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/tests/Loader/classloader/MethodImpl/InternalMethodImplTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ class F1
[MethodImpl(MethodImplOptions.NoInlining)] // The exception is thrown when restoring the caller with R2R
public F1()
{
var f2 = new F2();
// Keep the allocation observable so it isn't removed before the type is loaded
GC.KeepAlive(new F2());
}
}

Expand Down
2 changes: 2 additions & 0 deletions src/tests/Loader/classloader/StaticVirtualMethods/NegativeTestCases/MethodFlags.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,15 @@
.method public static void Test_Scenario1() cil managed noinlining
{
ldtoken BaseScenario1
call string [TypeHierarchyCommonCs]Statics::MakeName(valuetype [System.Runtime]System.RuntimeTypeHandle)
pop
ret
} // end of method Test_Scenario1

.method public static void Test_Scenario2() cil managed noinlining
{
ldtoken BaseScenario2
call string [TypeHierarchyCommonCs]Statics::MakeName(valuetype [System.Runtime]System.RuntimeTypeHandle)
pop
ret
} // end of method Test_Scenario1
Expand Down
1 change: 1 addition & 0 deletions ...ader/StaticVirtualMethods/NegativeTestCases/UnimplementedAbstractMethodOnConcreteClass.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
.method public static void Test_Scenario1() cil managed noinlining
{
ldtoken BaseScenario1
call string [TypeHierarchyCommonCs]Statics::MakeName(valuetype [System.Runtime]System.RuntimeTypeHandle)
pop
ret
} // end of method Test_Scenario1
Expand Down
2 changes: 2 additions & 0 deletions src/tests/Loader/classloader/StaticVirtualMethods/NegativeTestCases/VarianceSafety.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,15 @@
.method public static void Test_Scenario1() cil managed noinlining
{
ldtoken class InterfaceScenario1`1<object>
call string [TypeHierarchyCommonCs]Statics::MakeName(valuetype [System.Runtime]System.RuntimeTypeHandle)
pop
ret
} // end of method Test_Scenario1

.method public static void Test_Scenario2() cil managed noinlining
{
ldtoken class InterfaceScenario2`1<object>
call string [TypeHierarchyCommonCs]Statics::MakeName(valuetype [System.Runtime]System.RuntimeTypeHandle)
pop
ret
} // end of method Test_Scenario1
Expand Down
Loading