Repository navigation
[main] Forward-port SocketAsyncEventArgs address-family reuse fix - #136524
Merged
Merged
Conversation
Port the released .NET 11 RC3 fix and its regression tests from dotnet/dotnet commit 6f0fa48bddc8e7baaf5932d9340487ef12621103. Continue dotnet/dotnet#10450 in the runtime repository for component-level validation. Allocate the replacement native address buffer before freeing the previous buffer so an allocation failure leaves the existing allocation intact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c16c76d8-4d37-43f3-b2c4-890b9a3ce0a7
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
rbhanda
marked this pull request as ready for review
October 27, 2026 17:18
wfurt
approved these changes
Oct 27, 2026
rbhanda
enabled auto-merge (squash)
October 27, 2026 17:48
wfurt
approved these changes
Oct 27, 2026
MihaZupan
approved these changes
Oct 27, 2026
Member
|
/ba-g The build failure was #136543 |
Member
@MihaZupan which was already fixed on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-port the released .NET 11 RC3 SocketAsyncEventArgs address-family reuse fix to
dotnet/runtime/main.This continues dotnet/dotnet#10450 in the component repository for runtime-specific build and test coverage. The VMR PR remains open; this PR does not merge or close it.
SocketAddressand use the declared native buffer size forWSAMsg.Source and adaptation
The three-file fix comes from public dotnet/dotnet commit 6f0fa48bddc8e7baaf5932d9340487ef12621103, included in
v11.0.0-rc.3.26522.148. The paths are mapped fromsrc/runtime/into this repository.One intentional safety adjustment addresses the allocation-order comment on dotnet/dotnet#10450: allocate the replacement native buffer before freeing the previous allocation. If allocation throws, the event args retain the existing allocation and remain safe to dispose.
No servicing version changes or unrelated fixes are included.
Validation
git diff --checkpassed.dotnet build src\libraries\System.Net.Sockets\src\System.Net.Sockets.csproj --framework net11.0-windows --no-restore --nologoResult: 0 warnings, 0 errors.
@wfurt, please review the runtime forward-port, including the allocation-safety adjustment.
Note
This PR was prepared with GitHub Copilot.