Repository navigation
Avoid ConcurrentDictionary.Count on the Windows proxy lookup path - #136519
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 77df0a3f-9ca3-4c0e-99be-ffc9e57c41ca
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Member
Author
|
@MihaZupan can you take a look? I was just inspecting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid calling
ConcurrentDictionary.Counton every Windows system-proxy lookup, including when no proxies have failed.Countis expensive: it acquires all of the dictionary's locks and sums the per-lock counts to provide a snapshot. This adds dictionary-wide locking to an otherwise lock-free lookup.Check the cleanup deadline first and only inspect the cache size when cleanup is due. Empty and small caches still advance the deadline, keeping size checks throttled after the first interval.
Local before/after benchmarking showed faster proxy-cache lookups.