Skip to content

Exclude mixed-mode regression tests from ReadyToRun - #136442

Merged
steveisok merged 1 commit into
dotnet:mainfrom
steveisok:steveisok-mixed-mode-r2r-exclusions
Oct 25, 2026
Merged

steveisok merged 1 commit into
dotnet:mainfrom
steveisok:steveisok-mixed-mode-r2r-exclusions

Conversation

@steveisok

Copy link
Copy Markdown
Member

Fixes #136264.

The B03689Native.dll and B07847Native.dll C++/CLI helpers are mixed-mode assemblies that Crossgen2 explicitly rejects. Add <CrossGenTest>false</CrossGenTest> and <R2RIncompatible>true</R2RIncompatible> to b03689.csproj and b07847.csproj, matching the related mixed-mode TLS tests updated in #136266.

This prevents unsupported ReadyToRun compilation and skips execution in both ordinary and composite R2R runs. Ordinary JIT coverage remains enabled, and existing compatibility metadata and test assertions are unchanged. This does not change Crossgen2 support.

Validation

  • Passed: MSBuild evaluation of both actual projects for Windows x64 and arm64 Checked, plus complete batch and Bash wrapper generation using FetchExternalProperties,GenerateBatchExecutionScript,GenerateBashExecutionScript. All four configurations remain BuildAndRun, with _WillCLRTestProjectBuild=true and GenerateRunScript=true.
  • Passed: 16 generated Bash wrapper/control-flow checks using a probe launcher. Ordinary and composite R2R skip successfully before launch; ordinary JIT, including CompositeBuildMode alone without RunCrossGen2, reaches the probe launcher. These checks did not execute the Windows C++/CLI test assertions.
  • Passed: Inspection of the generated Windows batch wrappers confirms the R2R skip precedes the unchanged corerun.exe launch. Structural XML comparison confirms all pre-existing project settings and references are preserved. git diff --check passed.
  • Not run: Windows binaries were not built or executed on the macOS ARM64 host.

Resolves #136264

Note

This PR description was generated with GitHub Copilot.

Mark b03689 and b07847 as incompatible with Crossgen2 compilation and ReadyToRun execution while preserving normal JIT coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 25, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@steveisok
steveisok merged commit 0815b56 into dotnet:main Oct 25, 2026
82 checks passed
@github-project-automation github-project-automation Bot moved this to Done in AppModel Oct 25, 2026
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Test failure: JIT/Regression/CLR-x86-JIT/V1.2-M01/b03689/b03689/b03689.cmd

3 participants