Repository navigation
Fix HttpListener GetContext race with Close on Unix - #136298
Merged
Merged
Conversation
Fix `BeginGetContext()` and `GetContextAsync()` never completing in the managed `HttpListener` implementation if they race with `Stop()`, `Close()` or `Abort()`. `_state` is only updated after `Cleanup()` has drained the queue of pending operations, so an operation that passed the state check before the queue was drained could be added to it afterwards, and then nothing would ever complete it. Instead, record that the queue has been drained and complete such operations with an `ObjectDisposedException`, the same as operations that were already pending. Also adds a test that calls `BeginGetContext()` from multiple threads while the listener is terminated. Fixes dotnet#136293. Assisted-by: Claude Code <noreply@anthropic.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
martincostello
marked this pull request as ready for review
October 22, 2026 17:53
This was referenced Oct 23, 2026
wfurt
approved these changes
Oct 26, 2026
wfurt
left a comment
wfurt
left a comment
Member
There was a problem hiding this comment.
LGTM. thanks for the contribution @martincostello
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
BeginGetContext()andGetContextAsync()never completing in the managedHttpListenerimplementation if they race withStop(),Close()orAbort()._stateis only updated afterCleanup()has drained the queue of pending operations, so an operation that passed the state check before the queue was drained could be added to it afterwards, and then nothing would ever complete it. Instead, record that the queue has been drained and complete such operations with anObjectDisposedException, the same as operations that were already pending.Also adds a test that calls
BeginGetContext()from multiple threads while the listener is terminated.Fixes #136293.