Repository navigation
Stage matching PDBs for trimmed CoreCLR browser-Wasm builds - #136287
Merged
radekdoulik merged 3 commits intoOct 29, 2026
Merged
Conversation
Stage dependency symbols from the linked closure alongside their assemblies and select the final CoreCLR project assembly's PDB. Do not restore symbols removed by the linker; preserve Mono behavior. Add retained/removed-symbol publish-then-build coverage and document matching symbols and trimmed-interpreter validation. Fix dotnet#136286 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: aadf96ff-3cc2-4257-9781-b0130cb83781
radekdoulik
requested review from
akoeplinger,
ilonatommy,
lewing and
maraf
as code owners
October 22, 2026 13:04
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
jkotas
reviewed
Oct 22, 2026
Remove the symbol-staging paragraph from the library testing guide as requested in review. Keep the trimmed-interpreter instructions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: aadf96ff-3cc2-4257-9781-b0130cb83781
maraf
reviewed
Oct 23, 2026
Select symbol assets from the resolved publish files and invalidate stale compressed build symbols using the original asset identity. Read build candidates from the existing binlog, verify raw, gzip and Brotli publish symbols plus symbol removal, and avoid duplicate DLL existence checks. Generated with GitHub Copilot. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: aadf96ff-3cc2-4257-9781-b0130cb83781
maraf
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trimmed CoreCLR browser-Wasm builds paired ILLink-rewritten assemblies with compiler PDBs. The mismatched source mappings caused
StackTraceSymbolsFromMemoryto getnullinstead ofInMemorySymbols.cs.ComputeWasmPublishAssetsto use the resolved publish PDB and regenerate compressed symbols instead of reusing stale build assets.The build-side selection change is CoreCLR-only. The publish-task fix is shared with Mono.
Validation
macOS/arm64, Release libraries, Checked CoreCLR, Chrome:
5e628b94b24. Both rows fail against the original SDK.Mono/AOT and Windows execution, composite R2R, and the full Wasm.Build.Tests suite were not run.
Resolves #136286
Note
Generated with GitHub Copilot.