Repository navigation
[release/10.0] Update build and packaging Pkcs dependency to 9.0.21 - #136235
Merged
ViveliDuCh merged 1 commit intoOct 21, 2026
Merged
Conversation
Override the vulnerable transitive NuGet.Packaging dependency in all three affected projects using a shared version property. Keep NuGet vulnerability auditing enabled. Fixes dotnet#136231 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 792c8703-3703-4180-975a-9b86d809b48a
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Member
Author
|
/ba-g unrelated failure tracked in #136232 |
Member
Author
|
Tactics approved via email, adding the servicing-approved label |
tarekgh
approved these changes
Oct 21, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136231
main PR: Not available; this addresses the release/10.0 build dependency graph.
Description
Pin System.Security.Cryptography.Pkcs to 9.0.21 in Crossgen2Tasks, installer.tasks, and Microsoft.DotNet.CoreSetup.Packaging.Tests through a shared version property in eng/Versions.props.
These projects currently resolve Pkcs 9.0.6 transitively through NuGet.Packaging/7.0.3-rc.46203. Direct package references select the patched version without changing the NuGet toolset or suppressing vulnerability auditing.
Version 9.0.21 is the patched 9.x release listed in GHSA-846f-f764-76mx and GHSA-2fmv-rv2c-59x7.
This PR is separate from the MsQuic update in #136233.
Customer Impact
Release/10.0 builds fail package restore with NU1902 and NU1903 because the existing Pkcs dependency is affected by denial-of-service vulnerabilities. This blocks Windows and Linux build legs before tests can run.
Regression
Published advisories against the existing transitive dependency trigger the existing warnings-as-errors policy. This is not a product-code regression.
Testing
Windows x64, SDK 10.0.111:
.nupkgfiles are missing.Exact commands and results
.\dotnet.cmd restore .\src\tasks\Crossgen2Tasks\Crossgen2Tasks.csproj /p:TargetOS=windows /p:TargetArchitecture=x64 --no-cache -v:quiet.\dotnet.cmd restore .\src\tasks\installer.tasks\installer.tasks.csproj /p:TargetOS=windows /p:TargetArchitecture=x64 --no-cache -v:quiet.\dotnet.cmd restore .\src\installer\tests\Microsoft.DotNet.CoreSetup.Packaging.Tests\Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj /p:TargetOS=windows /p:TargetArchitecture=x64 --no-cache -v:quiet.\dotnet.cmd build .\src\tasks\Crossgen2Tasks\Crossgen2Tasks.csproj /p:TargetOS=windows /p:TargetArchitecture=x64 -v:quiet.\dotnet.cmd build .\src\tasks\installer.tasks\installer.tasks.csproj /p:TargetOS=windows /p:TargetArchitecture=x64 -v:quiet.\dotnet.cmd build .\src\installer\tests\Microsoft.DotNet.CoreSetup.Packaging.Tests\Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj /p:TargetOS=windows /p:TargetArchitecture=x64 -v:quiet.\dotnet.cmd build .\src\installer\tests\Microsoft.DotNet.CoreSetup.Packaging.Tests\Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj /p:TargetOS=windows /p:TargetArchitecture=x64 /p:SkipBuildingSharedFrameworkTestDependencies=true -v:quiet.\dotnet.cmd test .\artifacts\bin\Microsoft.DotNet.CoreSetup.Packaging.Tests\Debug\net10.0\Microsoft.DotNet.CoreSetup.Packaging.Tests.dll --filter "category!=failing" --logger "console;verbosity=normal"Risk
Low: a servicing patch update to a build/test dependency, with no product source changes or audit suppressions. All affected dependency graphs restore successfully and the task and test assemblies compile. Full package-dependent tests remain unverified because their product artifacts are missing locally.
Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.