Repository navigation
Require threads for ControlledExecutionTests.CancelInTryAndExitCatchNormally - #136116
Merged
lewing merged 1 commit intoOct 20, 2026
Merged
Conversation
CancelInTryAndExitCatchNormally cancels its action from a Task.Run task while the action spins. dotnet#135915 moved the IsMultithreadingSupported condition from the ControlledExecutionTests class onto the four enabled tests that do this. dotnet#135939 enabled this test again from a branch that predated dotnet#135915, so the test has no such condition. On single-threaded wasm the task cannot run while the action spins, which is the likely cause of the System.Runtime.Tests timeouts in the browser-wasm library tests. Add the condition, as the other Task.Run tests have.
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
lewing
approved these changes
Oct 20, 2026
jkotas
approved these changes
Oct 20, 2026
Member
|
/ba-g fast merging test fix |
Contributor
Author
|
Thank you for the review and the merge. |
This was referenced Oct 20, 2026
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test cancels its action from a
Task.Runtask while the action spins. #135915 and #135939 merged a minute apart, and each changed this class:IsMultithreadingSupportedfrom the class onto the four enabled tests that cancel fromTask.Run.CancelInTryAndExitCatchNormallyagain, but its branch predated Do not adjust wasm virtual IPs in the thread abort stack walk #135915, so on main the test has no such condition.On single-threaded wasm, the canceling task cannot run while the action spins. In the browser-wasm
LibraryTestsCoreCLRleg,System.Runtime.Testshad these results:Under
src/libraries, #135939 changed only this test's attribute. The log does not name the test that was running.Both PRs are mine, and I missed the interaction before they merged.
Note
This PR was prepared with AI assistance (Anthropic Claude, checked by OpenAI Codex) at my request. I reviewed it before posting it.