Repository navigation
[browser] Make SystemJS_GetLocaleInfo argument order consistent - #135983
Merged
Merged
Conversation
The TS implementations and the managed caller used (culture, locale) while the C declarations and interop signatures use (locale, culture). Swap the order in the TS implementations (CoreCLR and Mono) and in the managed caller so every layer agrees. No behavior change. Fixes #135439 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 58481b1b-2e0e-4033-971e-7adef84564bf
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
tarekgh
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
This was referenced Oct 17, 2026
Closed
pavelsavara
approved these changes
Oct 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SystemJS_GetLocaleInfois declared in C and managed interop as(locale, culture, ...): the locale being described, then the display language. Both TS implementations and the CoreLib caller used(culture, locale, ...). The swaps cancel in-tree, but a caller following the declaration gets the wrong result (describingfr-FRinen-USreturnsanglais##États-Unis). This swaps the TS parameters to match and updatesJSGetLocaleInfo/JSGetNativeDisplayNameand their callers, so in-tree behavior is unchanged.Resolves #135439
Note
This PR description was generated with GitHub Copilot.