Repository navigation
Resolve WASI SDK for NativeAOT runtime test builds - #135952
Merged
MichalStrehovsky merged 1 commit intoOct 20, 2026
Merged
Conversation
Acquire the shared WASI SDK and set WASI_SDK_PATH before native linker setup in each NativeAOT WASI project. Grouped test builds launch separate MSBuild processes, so target-computed outer properties do not propagate. Exclude WASM from Unix rpath arguments, which its linker does not support. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a6f3a617-acae-4f4f-95d3-20b2a0bac43c
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Reported validation depends on unmerged enablement, leaving standalone branch and Unix-host builds unverified.
No open issues 🎉
What changed in this PR
Resolves the shared WASI SDK within each NativeAOT runtime-test project, supporting grouped builds that use separate MSBuild processes.
Changes:
- Imports SDK acquisition and sets
WASI_SDK_PATHbefore OS-specific linker setup. - Excludes WASM targets from Unix rpath linker arguments.
| File | Description |
|---|---|
| src/tests/Directory.Build.targets | Adds per-project WASI SDK resolution and excludes WASM from Unix rpath arguments. |
Review effort: Balanced
Member
Author
|
@dotnet/ilc-contrib could someone have a look? This is only doing a couple things:
|
jkotas
approved these changes
Oct 20, 2026
Member
Author
|
Thanks! |
Member
Author
|
/ba-g failure was #135963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve the shared WASI SDK for NativeAOT runtime-test projects.
Import
AcquireWasiSdk.targetsfor NativeAOT WASI tests and populateWASI_SDK_PATHbefore the NativeAOT OS-specific linker setup. Perform this in each test project because grouped test builds run in separate MSBuild processes and do not inherit properties computed by an outer target.Also exclude WASM from the test infrastructure's Unix rpath linker argument.
Validation
On the combined local NativeAOT WASI bringup tree, including other unmerged enablement:
.\src\tests\build.cmd nativeaot checked test nativeaot\SmokeTests\AttributeTrimming\AttributeTrimming.csproj wasm wasipassed, including after deleting the test artifacts..\src\tests\build.cmd nativeaot checked tree nativeaot wasm wasireached test compilation/linking; the latest run failed only on the existingUnitTestslowering assertion, with C math ABI warnings also remaining.This branch contains only this cherry-picked commit from
main; it was not built independently. Automated execution integration and Unix-host validation are not included.Note
This PR description was generated by GitHub Copilot.