Repository navigation
Validate ZstandardStream constructor arguments and prevent ArrayPool buffer leak on failure - #135934
Merged
rzikm merged 1 commit intoOct 16, 2026
Conversation
…buffer leak on failure - Validate compressionOptions with ArgumentNullException.ThrowIfNull before calling Init in ZstandardStream(Stream, ZstandardCompressionOptions, bool). - Validate compressionLevel before calling Init in ZstandardStream(Stream, CompressionLevel, bool) to avoid renting a buffer when GetQualityFromCompressionLevel throws ArgumentOutOfRangeException. - Dispose _buffer in try-catch blocks if encoder or decoder instantiation fails after Init. - Add unit tests for constructor argument validation.
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/area-system-io-compression |
Contributor
Author
|
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135933
Description
This PR addresses constructor argument validation and resource cleanup in
ZstandardStream:ArgumentNullException.ThrowIfNull(compressionOptions)before callingInitinZstandardStream(Stream, ZstandardCompressionOptions, bool), and updated the XML documentation.qualitybeforeInitinZstandardStream(Stream, CompressionLevel, bool)so invalidCompressionLevelenum values throwArgumentOutOfRangeExceptionbefore renting the internal 64 KB buffer.Initin try-catch blocks to dispose_bufferif native context allocation or configuration throws.nullcompression options and out-of-range compression levels.