Repository navigation
Conversation
mrek-msft
requested review from
rosebyte and
svick
and
a balanced review from Copilot
October 16, 2026 05:34
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The bounded, test-only waits preserve existing assertions and introduce no blocking issues.
1 open finding
What changed in this PR
Addresses the configuration reload test race reported in #135612 without changing production behavior.
Changes:
- Waits for reload tokens alongside expected configuration values.
- Adds a token wait to the reload-error test.
Validation was limited to source inspection; no builds or tests were run.
| File | Description |
|---|---|
| src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs | Waits for reload notifications before asserting token state. |
🧠 Review effort: Balanced
This was referenced Oct 16, 2026
Closed
rosebyte
approved these changes
Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #135612