Repository navigation
Conversation
Add PACKAGE.md for Microsoft.Extensions.Logging.Configuration and remove the EnableDefaultPackageReadmeFile=false opt-out and its TODO so the readme is included in the package. Contributes to dotnet#99358.
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-logging |
Author
|
@dotnet-policy-service agree |
This was referenced Oct 16, 2026
Closed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a package README for Microsoft.Extensions.Logging.Configuration, following the section layout of the other Microsoft.Extensions.Logging.* packages.
This also removes
EnableDefaultPackageReadmeFile=falseand the TODO comment from the project file, soPACKAGE.mdis included in the package.Validation:
ValidatePackageReadmeExistspasses (and fails as expected whenPackageReadmeFilePathpoints at a missing file)./build.sh libs,dotnet packsucceeds and the resulting nupkg containsPACKAGE.mdwith<readme>PACKAGE.md</readme>in the nuspecgit diff --checkpassesContributes to #99358.
Note
This PR description and the package README were drafted with AI assistance (Claude) and reviewed by me. The sample code was compiled and run locally.