Repository navigation
Clarify async validation source documentation from API docs review - #135691
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 34759cec-00a3-4d2e-b5c2-05b2e882b21c
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-componentmodel-dataannotations |
This was referenced Oct 13, 2026
Closed
tarekgh
reviewed
Oct 13, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0e4f9f74-7009-4e9f-8a00-4abfafca6592
tarekgh
approved these changes
Oct 13, 2026
Member
Author
|
/backport to release/11.0 |
Contributor
|
Started backporting to |
2 of 4 tasks
ViveliDuCh
added a commit
that referenced
this pull request
Oct 14, 2026
… docs review (#135750) Backport of #135691 to release/11.0 /cc @ViveliDuCh Clarifies guidance for the public `IValidatableObject` validation entry points and improves wording following API-reference review feedback. ## Customer Impact - [ ] Customer reported - [x] Found internally Adds API documentation guidance for the new .NET 11 asynchronous validation feature. ## Regression - [ ] Yes - [x] No Documentation update for a new feature. ## Testing Documentation-only change. Reviewed the backport diff; all changes are XML documentation comments. No build or tests run for this backport. ## Risk Low; API documentation only, with no runtime behavior or API shape changes. Co-authored-by: Viviana Dueñas <50237907+ViveliDuCh@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 34759cec-00a3-4d2e-b5c2-05b2e882b21c Copilot-Session: 0e4f9f74-7009-4e9f-8a00-4abfafca6592
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OperationCanceledExceptionon all eight asynchronousValidatoroverloads andAsyncValidationAttribute.GetValidationResultAsync.ValidateObjectAsyncoverloads, including the nonrecursive scope ofvalidateAllProperties.ValidationExceptionoverload, while preserving the distinction from the inner-exception overload.These changes affect only XML comments in four source files. They preserve the previously addressed review feedback and do not change executable code, API signatures, reference assemblies, or documentation ownership settings. Existing Options guidance already addresses the applicable feedback and is unchanged.
System.ComponentModel.Annotationsreference documentation is maintained indotnet/dotnet-api-docson dotnet/dotnet-api-docs#13101. These source-alignment changes do not replace the matching direct ECMAXML updates there.Validation
src\libraries\System.ComponentModel.Annotations\src\System.ComponentModel.Annotations.csprojsuccessfully with zero warnings and zero errors.git diff --checkpasses.Note
This PR description and the source documentation updates were prepared with GitHub Copilot.