Repository navigation
Delete CodeHeapReserveForJumpStubs - #135411
Merged
Merged
Conversation
With the new precode design, we do not need to guarantee jumpstubs allocation succeeds anymore. All jump stub allocation can retry in the very rare case we are not able to find memory for the jump stub in the right range.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The jump-stub design document still describes the removed settings and fatal failure behavior.
1 open finding
What changed in this PR
Reworks jump-stub allocation failures to retry instead of relying on reserved code-heap space or fatal range-specific OOM handling.
Changes:
- Removes jump-stub heap reservations, configuration switches, and dedicated OOM resources.
- Propagates allocation failure as
NULLso JIT compilation can retry. - Adds AMD64 dynamic-helper emission retries at new addresses.
| File | Description |
|---|---|
src/coreclr/vm/threads.h |
Removes a redundant access specifier. |
src/coreclr/vm/jitinterface.cpp |
Adapts relocation handling to nullable jump-stub allocation. |
src/coreclr/vm/dynamicmethod.cpp |
Returns failure for unsatisfied ranged allocations. |
src/coreclr/vm/codeman.h |
Simplifies allocation state and jump-stub APIs. |
src/coreclr/vm/codeman.cpp |
Removes reservations and fatal range-OOM handling. |
src/coreclr/vm/amd64/cgencpu.h |
Updates the AMD64 relocation helper contract. |
src/coreclr/vm/amd64/cgenamd64.cpp |
Retries dynamic-helper emission after allocation failure. |
src/coreclr/pal/src/map/virtual.cpp |
Updates executable-memory reservation commentary. |
src/coreclr/inc/clrconfigvalues.h |
Removes obsolete jump-stub settings. |
src/coreclr/dlls/mscorrc/resource.h |
Removes the range-OOM resource identifier. |
src/coreclr/dlls/mscorrc/mscorrc.rc |
Removes the corresponding error message. |
src/coreclr/debug/daccess/fntableaccess.h |
Keeps the diagnostic heap-layout mirror synchronized. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
pcshrosbree
reviewed
Oct 8, 2026
pcshrosbree
reviewed
Oct 8, 2026
pcshrosbree
reviewed
Oct 9, 2026
pcshrosbree
left a comment
pcshrosbree
left a comment
Contributor
There was a problem hiding this comment.
Built Checked clr and the readytorun tests on linux-x64 at e8fae2e. All 24 pass on this head and the merge-base, with and without DOTNET_ForceRelocs=1. With injected jump-stub failures, every dynamic-helper retry moved to a new address and ended within about 1 KB.
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
AaronRobinsonMSFT
approved these changes
Oct 12, 2026
Member
Author
|
/azp run runtime-coreclr r2r-extra |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Member
Author
|
/ba-g failure is known issue #132291 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new precode design, we do not need to guarantee jumpstubs allocation succeeds anymore. All jump stub allocation can retry in the very rare case we are not able to find memory for the jump stub in the right range.